[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F
From: |
Kashyap Chamarthy |
Subject: |
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F |
Date: |
Tue, 10 Mar 2020 15:53:49 +0100 |
On Tue, Mar 10, 2020 at 07:15:29AM -0500, Eric Blake wrote:
> On 3/10/20 4:47 AM, Kashyap Chamarthy wrote:
[...]
> > <digression>
> >
> > Ah, didn't realize the inconsistency of 'convert' lacking the '-F'
> > shorthand ... which reminds me, there are at least _three_ ways that I
> > know of, to specify backing file format with 'create':
> >
> > $ qemu-img create -f qcow2 -o
> > 'backing_file=./base.raw,backing_fmt=raw' ./overlay1.qcow2
> > $ qemu-img create -f qcow2 -b ./base.raw -o backing_fmt=raw
> > overlay1.qcow2
> > $ qemu-img create -f qcow2 -b ./base.raw -F raw ./overlay1.qcow2
> >
> > I'm wondering about the consistency of having all the above three
> > supported for other operations too. Now I at least know 'convert' lacks
> > the "-F".
>
> The -o forms (backing_file= and backing_fmt=) always work. Various commands
> then have additional shorthand: -b/-F for create, -B for convert. You're
> right that we aren't very consistent, but I'm reluctant to change the
> inconsistencies in this patch
Oh, I wasn't implying to tackle the inconsistency as part of this
patch, or series. Hence the 'digression' :-) Was just wondering out
loud.
> (at one point in the past, we tried to get rid
> of the shorthand and force all users to go through -o, but that broke too
> many clients that were depending on the undocumented shorthand, so we
> documented the existing shorthand instead).
Fair enough; let's not touch these things for now.
--
/kashyap
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, (continued)
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Kevin Wolf, 2020/03/09
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Kevin Wolf, 2020/03/09
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Eric Blake, 2020/03/09
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Daniel P . Berrangé, 2020/03/09
- Re: [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk, Eric Blake, 2020/03/09
[PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/06
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Kashyap Chamarthy, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Kashyap Chamarthy, 2020/03/10
Re: [PATCH v3 4/4] qemu-img: Deprecate use of -b without -F, Eric Blake, 2020/03/13
[PATCH v3 3/4] block: Add support to warn on backing file change without format, Eric Blake, 2020/03/06
[PATCH v3 2/4] iotests: Specify explicit backing format where sensible, Eric Blake, 2020/03/06