Re: [PATCH v3 9/9] block/block-copy: hide structure definitions

[Max Reitz]

On 06.03.20 08:38, Vladimir Sementsov-Ogievskiy wrote:
> Hide structure definitions and add explicit API instead, to keep an
> eye on the scope of the shared fields.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  include/block/block-copy.h | 52 +++----------------------------
>  block/backup-top.c         |  6 ++--
>  block/backup.c             | 25 +++++++--------
>  block/block-copy.c         | 63 ++++++++++++++++++++++++++++++++++++--
>  4 files changed, 82 insertions(+), 64 deletions(-)

[...]

> diff --git a/block/block-copy.c b/block/block-copy.c
> index d66b8eb691..a2d8579ca0 100644
> --- a/block/block-copy.c
> +++ b/block/block-copy.c

[...]

>  static BlockCopyInFlightReq *find_conflicting_inflight_req(BlockCopyState *s,
> -                                                          int64_t offset,
> -                                                          int64_t bytes)
> +                                                           int64_t offset,
> +                                                           int64_t bytes)

Now I see why Andrey says that the alignment fits; this should be
squashed into patch 7.

With that done:

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature