[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/16]: hw/i386/vmport: Bug fixes and improvements

From: Michael S. Tsirkin
Subject: Re: [PATCH v2 00/16]: hw/i386/vmport: Bug fixes and improvements
Date: Tue, 10 Mar 2020 13:44:45 -0400

On Tue, Mar 10, 2020 at 06:53:16PM +0200, Liran Alon wrote:
> Hi,
> This series aims to fix several bugs in VMPort and improve it by supporting
> more VMPort commands and make command results more configurable to
> user via QEMU command-line.
> This functionality was proven to be useful to run various VMware VMs
> when attempting to run them as-is on top of QEMU/KVM.
> For more details, see commit messages.

Well two versions in one day and some review comments weren't addressed.
Some people do this, try to wear the maintainers out by sheer volume.
It works sometimes but it's not a nice tactic. I personally think it's
worth taking the time to think harder about ways to address all
comments, not try to dismiss them.


> Regards,
> -Liran
> v1->v2:
> * Fix coding convention [Patchew Bot & MST].
> * Create new header file for vmport.h [MST].
> * Move KVM_APIC_BUS_FREQUENCY from linux-headers/asm-x86/kvm.h
>   auto-generated header [MST]
> * Elaborate more that vmx-version refers to the VMware userspace
>   VMM in commit message. [MST]
> * Use le32_to_cpu() on BIOS_UUID vmport command. [MST]
> * Introduce VMPort compatability version property to maintain migration
>   compatibility. [MST]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]