[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v6 04/13] hw/i386: Remove unnecessary initialization in x86_cpu_n

From: Babu Moger
Subject: [PATCH v6 04/13] hw/i386: Remove unnecessary initialization in x86_cpu_new
Date: Tue, 10 Mar 2020 21:33:44 -0500
User-agent: StGit/unknown-version

The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
So, remove the initialization here.

Suggested-by: Igor Mammedov <address@hidden>
Signed-off-by: Babu Moger <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
 hw/i386/x86.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index 03b8962c98..79badcc4ec 100644
--- a/hw/i386/x86.c
+++ b/hw/i386/x86.c
@@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_id, 
Error **errp)
     Object *cpu = NULL;
     Error *local_err = NULL;
-    CPUX86State *env = NULL;
     cpu = object_new(MACHINE(x86ms)->cpu_type);
-    env = &X86_CPU(cpu)->env;
-    env->nr_dies = x86ms->smp_dies;
     object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
     object_property_set_bool(cpu, true, "realized", &local_err);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]