[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup
From: |
Richard Henderson |
Subject: |
Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup |
Date: |
Tue, 10 Mar 2020 23:07:14 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/9/20 8:43 AM, Peter Maydell wrote:
> doc-good.json tests some oddities of markup that we don't want to
> accept. Make them match the more restrictive rST syntax:
>
> * in a single list the bullet types must all match
> * lists must have leading and following blank lines
> * indentation is important
> * the '|' example syntax is going to go away entirely, so stop
> testing it
>
> This will avoid the tests spuriously breaking when we tighten up the
> parser code in the following commits.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> New patch in v2
> ---
> tests/qapi-schema/doc-good.json | 25 +++++++++++++------------
> tests/qapi-schema/doc-good.out | 12 ++++++------
> tests/qapi-schema/doc-good.texi | 12 +++---------
> 3 files changed, 22 insertions(+), 27 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v4 00/18] Convert QAPI doc comments to generate rST instead of texinfo, Peter Maydell, 2020/03/09
- [PATCH v4 02/18] qapi/qapi-schema.json: Put headers in their own doc-comment blocks, Peter Maydell, 2020/03/09
- [PATCH v4 03/18] qapi/machine.json: Escape a literal '*' in doc comment, Peter Maydell, 2020/03/09
- [PATCH v4 05/18] scripts/qapi: Move doc-comment whitespace stripping to doc.py, Peter Maydell, 2020/03/09
- [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup, Peter Maydell, 2020/03/09
- Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup,
Richard Henderson <=
- [PATCH v4 01/18] qapi/migration.json: Fix indentation, Peter Maydell, 2020/03/09
- [PATCH v4 06/18] scripts/qapi/parser.py: improve doc comment indent handling, Peter Maydell, 2020/03/09
- [PATCH v4 07/18] docs/sphinx: Add new qapi-doc Sphinx extension, Peter Maydell, 2020/03/09
- [PATCH v4 08/18] docs/interop: Convert qemu-ga-ref to rST, Peter Maydell, 2020/03/09
- [PATCH v4 10/18] qapi: Use rST markup for literal blocks, Peter Maydell, 2020/03/09