[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] aio-posix: remove confusing QLIST_SAFE_REMOVE()
From: |
Stefan Hajnoczi |
Subject: |
[PULL 2/9] aio-posix: remove confusing QLIST_SAFE_REMOVE() |
Date: |
Wed, 11 Mar 2020 12:40:38 +0000 |
QLIST_SAFE_REMOVE() is confusing here because the node must be on the
list. We actually just wanted to clear the linked list pointers when
removing it from the list. QLIST_REMOVE() now does this, so switch to
it.
Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Link: https://lore.kernel.org/r/address@hidden
Message-Id: <address@hidden>
---
util/aio-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 9e1befc0c0..b339aab12c 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -493,7 +493,7 @@ static bool aio_dispatch_ready_handlers(AioContext *ctx,
AioHandler *node;
while ((node = QLIST_FIRST(ready_list))) {
- QLIST_SAFE_REMOVE(node, node_ready);
+ QLIST_REMOVE(node, node_ready);
progress = aio_dispatch_handler(ctx, node) || progress;
}
--
2.24.1
- [PULL 0/9] Block patches, Stefan Hajnoczi, 2020/03/11
- [PULL 1/9] qemu/queue.h: clear linked list pointers on remove, Stefan Hajnoczi, 2020/03/11
- [PULL 2/9] aio-posix: remove confusing QLIST_SAFE_REMOVE(),
Stefan Hajnoczi <=
- [PULL 3/9] aio-posix: completely stop polling when disabled, Stefan Hajnoczi, 2020/03/11
- [PULL 4/9] aio-posix: move RCU_READ_LOCK() into run_poll_handlers(), Stefan Hajnoczi, 2020/03/11
- [PULL 6/9] aio-posix: simplify FDMonOps->update() prototype, Stefan Hajnoczi, 2020/03/11
- [PULL 7/9] aio-posix: add io_uring fd monitoring implementation, Stefan Hajnoczi, 2020/03/11
- [PULL 8/9] aio-posix: support userspace polling of fd monitoring, Stefan Hajnoczi, 2020/03/11
- [PULL 9/9] aio-posix: remove idle poll handlers to improve scalability, Stefan Hajnoczi, 2020/03/11
- [PULL 5/9] aio-posix: extract ppoll(2) and epoll(7) fd monitoring, Stefan Hajnoczi, 2020/03/11
- Re: [PULL 0/9] Block patches, no-reply, 2020/03/11
- Re: [PULL 0/9] Block patches, no-reply, 2020/03/11