[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND 1/3] vfio/pci: fix a null pointer reference in vfio_ro
From: |
Laszlo Ersek |
Subject: |
Re: [PATCH RESEND 1/3] vfio/pci: fix a null pointer reference in vfio_rom_read |
Date: |
Wed, 11 Mar 2020 14:00:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 03/11/20 12:54, Markus Armbruster wrote:
> Laszlo Ersek <address@hidden> writes:
>> In fact I was about to mention, "I really don't understand why compilers
>> don't yell upon seeing pointer-to-void arithmetic", but I got distracted
>> and forgot about that thought. In retrospect, that may have been for the
>> best! :)
>
> You're looking for
>
> '-Wpointer-arith'
> Warn about anything that depends on the "size of" a function type
> or of 'void'. GNU C assigns these types a size of 1, for
> convenience in calculations with 'void *' pointers and pointers to
> functions. In C++, warn also when an arithmetic operation involves
> 'NULL'. This warning is also enabled by '-Wpedantic'.
>
Thanks! It seems like "-Wpedantic" and "-pedantic" are synonymous. And
the latter used to be part of my standard set of flags, while I worked
on hosted C programs where I could influence the build flags ;)
Cheers,
Laszlo