[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 0/9] Block patches
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PULL 0/9] Block patches |
|
Date: |
Wed, 11 Mar 2020 16:55:20 +0000 |
On Wed, Mar 11, 2020 at 06:51:46AM -0700, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
...
> === OUTPUT BEGIN ===
> 1/9 Checking commit 86ac8a79649d (qemu/queue.h: clear linked list pointers on
> remove)
> ERROR: do not use assignment in if condition
> #66: FILE: include/qemu/queue.h:314:
> + if (((head)->sqh_first = elm->field.sqe_next) == NULL) \
>
> total: 1 errors, 0 warnings, 59 lines checked
This is for consistency with the rest of queue.h, which comes from BSD
and does not follow QEMU coding style.
Stefan
signature.asc
Description: PGP signature
- [PULL 3/9] aio-posix: completely stop polling when disabled, (continued)
- [PULL 3/9] aio-posix: completely stop polling when disabled, Stefan Hajnoczi, 2020/03/11
- [PULL 4/9] aio-posix: move RCU_READ_LOCK() into run_poll_handlers(), Stefan Hajnoczi, 2020/03/11
- [PULL 6/9] aio-posix: simplify FDMonOps->update() prototype, Stefan Hajnoczi, 2020/03/11
- [PULL 7/9] aio-posix: add io_uring fd monitoring implementation, Stefan Hajnoczi, 2020/03/11
- [PULL 8/9] aio-posix: support userspace polling of fd monitoring, Stefan Hajnoczi, 2020/03/11
- [PULL 9/9] aio-posix: remove idle poll handlers to improve scalability, Stefan Hajnoczi, 2020/03/11
- [PULL 5/9] aio-posix: extract ppoll(2) and epoll(7) fd monitoring, Stefan Hajnoczi, 2020/03/11
- Re: [PULL 0/9] Block patches, no-reply, 2020/03/11
- Re: [PULL 0/9] Block patches, no-reply, 2020/03/11
- Re: [PULL 0/9] Block patches,
Stefan Hajnoczi <=
- Re: [PULL 0/9] Block patches, Peter Maydell, 2020/03/11