Re: [PATCH v2 1/1] modules: load modules from versioned /var/run dir

[Paolo Bonzini]

On 10/03/20 16:47, Daniel P. Berrangé wrote:
> On Tue, Mar 10, 2020 at 03:58:06PM +0100, Christian Ehrhardt wrote:
>> On upgrades the old .so files usually are replaced. But on the other
>> hand since a qemu process represents a guest instance it is usually kept
>> around.
>>
>> That makes late addition of dynamic features e.g. 'hot-attach of a ceph
>> disk' fail by trying to load a new version of e.f. block-rbd.so into an
>> old still running qemu binary.
>>
>> This adds a fallback to also load modules from a versioned directory in the
>> temporary /var/run path. That way qemu is providing a way for packaging
>> to store modules of an upgraded qemu package as needed until the next reboot.
>>
>> An example how that can then be used in packaging can be seen in:
>> https://git.launchpad.net/~paelzer/ubuntu/+source/qemu/log/?h=bug-1847361-miss-old-so-on-upgrade-UBUNTU
>>
>> Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1847361
>> Signed-off-by: Christian Ehrhardt <address@hidden>
>> ---
>>  configure     | 15 +++++++++++++++
>>  util/module.c | 14 ++++++++++++++
>>  2 files changed, 29 insertions(+)
> 
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> 
> 
> Regards,
> Daniel
> 

Queued, thanks.

Paolo