[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/16] accel/tcg: Add probe_access_flags
From: |
Richard Henderson |
Subject: |
Re: [PATCH 02/16] accel/tcg: Add probe_access_flags |
Date: |
Wed, 11 Mar 2020 21:38:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/10/20 11:44 PM, Richard Henderson wrote:
> +int probe_access_flags(CPUArchState *env, target_ulong addr,
> + MMUAccessType access_type, int mmu_idx,
> + bool nonfault, void **phost, uintptr_t retaddr)
> +{
> + void *host;
> + int flags;
> +
> + flags = probe_access_internal(env, addr, 0, access_type, mmu_idx,
> + nonfault, &host, retaddr);
Bug here. Should have passed along phost to probe_access_internal instead of a
new local host variable.
I've sent a v2 for this patch, in-reply-to. I'll not repost the whole patch
set until I've also addressed any review.
r~
- [PATCH 00/16] target/arm: sve load/store improvements, Richard Henderson, 2020/03/11
- [PATCH 01/16] accel/tcg: Add block comment for probe_access, Richard Henderson, 2020/03/11
- [PATCH 03/16] exec: Add cpu_probe_watchpoint, Richard Henderson, 2020/03/11
- [PATCH 02/16] accel/tcg: Add probe_access_flags, Richard Henderson, 2020/03/11
- [PATCH 04/16] target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn, Richard Henderson, 2020/03/11
- [PATCH 05/16] target/arm: Drop manual handling of set/clear_helper_retaddr, Richard Henderson, 2020/03/11
- [PATCH 09/16] target/arm: Handle watchpoints in sve_ld1_r, Richard Henderson, 2020/03/11
- [PATCH 06/16] target/arm: Add sve infrastructure for page lookup, Richard Henderson, 2020/03/11
- [PATCH 08/16] target/arm: Use SVEContLdSt in sve_ld1_r, Richard Henderson, 2020/03/11
- [PATCH 07/16] target/arm: Adjust interface of sve_ld1_host_fn, Richard Henderson, 2020/03/11
- [PATCH 10/16] target/arm: Use SVEContLdSt for multi-register contiguous loads, Richard Henderson, 2020/03/11
- [PATCH 11/16] target/arm: Update contiguous first-fault and no-fault loads, Richard Henderson, 2020/03/11
- [PATCH 12/16] target/arm: Use SVEContLdSt for contiguous stores, Richard Henderson, 2020/03/11
- [PATCH 13/16] target/arm: Reuse sve_probe_page for gather first-fault loads, Richard Henderson, 2020/03/11