qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/14] LUKS: encryption slot management using amend interf


From: Eric Blake
Subject: Re: [PATCH v2 00/14] LUKS: encryption slot management using amend interface
Date: Thu, 12 Mar 2020 06:56:27 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/8/20 10:18 AM, Maxim Levitsky wrote:
Hi!
Here is the updated series of my patches, incorporating all the feedback I 
received.


Patches are strictly divided by topic to 3 groups, and each group depends on 
former groups.

* Patches 1,2 implement qcrypto generic amend interface, including definition
   of structs used in crypto.json and implement this in luks crypto driver
   Nothing is exposed to the user at this stage

* Patches 3-9 use the code from patches 1,2 to implement qemu-img amend based 
encryption slot management
   for luks and for qcow2, and add a bunch of iotests to cover that.

* Patches 10-13 add x-blockdev-amend (I'll drop the -x prefix if you like), and 
wire it
   to luks and qcow2 driver to implement qmp based encryption slot management 
also using
   the code from patches 1,2, and also add a bunch of iotests to cover this.

  tests/qemu-iotests/284.out       |   6 +-
  tests/qemu-iotests/300           | 207 ++++++++++++++++

Any reason why you skipped straight to test 300, rather than using an available slot like 290? (Admittedly, our process for reserving slots is not very high-tech: manually scan the list for what other patches out there have claimed a slot, and be prepared to renumber when rebasing)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]