[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its
From: |
Mark Cave-Ayland |
Subject: |
[PATCH 4/7] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default value |
Date: |
Fri, 13 Mar 2020 08:24:41 +0000 |
Some firmwares accidentally write to PCI_INTERRUPT_LINE on startup which has
no effect on real hardware since it is hard-wired to its default value, but
causes the guest OS to become confused trying to initialise IDE devices
when running under QEMU.
Signed-off-by: Mark Cave-Ayland <address@hidden>
---
hw/ide/via.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/via.c b/hw/ide/via.c
index 3153be8862..8363bd4802 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -169,7 +169,7 @@ static void via_ide_realize(PCIDevice *dev, Error **errp)
pci_config_set_prog_interface(pci_conf, 0x8f); /* native PCI ATA mode */
pci_set_long(pci_conf + PCI_CAPABILITY_LIST, 0x000000c0);
- dev->wmask[PCI_INTERRUPT_LINE] = 0xf;
+ dev->wmask[PCI_INTERRUPT_LINE] = 0;
memory_region_init_io(&d->data_bar[0], OBJECT(d), &pci_ide_data_le_ops,
&d->bus[0], "via-ide0-data", 8);
--
2.20.1
- [PATCH 0/7] via-ide: fixes and improvements, Mark Cave-Ayland, 2020/03/13
- [PATCH 1/7] via-ide: move registration of VMStateDescription to DeviceClass, Mark Cave-Ayland, 2020/03/13
- [PATCH 3/7] pci: Honour wmask when resetting PCI_INTERRUPT_LINE, Mark Cave-Ayland, 2020/03/13
- [PATCH 2/7] ide/via: Get rid of via_ide_init(), Mark Cave-Ayland, 2020/03/13
- [PATCH 4/7] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default value,
Mark Cave-Ayland <=
- [PATCH 5/7] via-ide: initialise IDE controller in legacy mode, Mark Cave-Ayland, 2020/03/13
- [PATCH 6/7] via-ide: allow guests to write to PCI_CLASS_PROG, Mark Cave-Ayland, 2020/03/13
- [PATCH 7/7] via-ide: always use legacy IRQ 14/15 routing, Mark Cave-Ayland, 2020/03/13
- Re: [PATCH 0/7] via-ide: fixes and improvements, BALATON Zoltan, 2020/03/13
- Re: [EXTERNAL][PATCH 0/7] via-ide: fixes and improvements, Aleksandar Markovic, 2020/03/13
- Re: [PATCH 0/7] via-ide: fixes and improvements, John Snow, 2020/03/13