[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] exec/rom_reset: Free rom data during inmigrate skip |
|
Date: |
Fri, 13 Mar 2020 14:23:41 +0000 |
On Fri, 13 Mar 2020 at 13:57, Dr. David Alan Gilbert
<address@hidden> wrote:
> Ah yes, I think you're right, so something like:
>
> if (runstate_check(RUN_STATE_INMIGRATE) && rom->data && rom->isrom) {
I think you would see the difference here for images
loaded into RAM, rather than ROM -- they need to be
reinstated on reset, because the guest can scribble
on them. So we retain the data and don't free it.
thanks
-- PMM