Re: [PATCH v2] exec/rom_reset: Free rom data during inmigrate skip

[Peter Maydell]

On Fri, 13 Mar 2020 at 15:59, Dr. David Alan Gilbert (git)
<address@hidden> wrote:
>
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Commit 355477f8c73e9 skips rom reset when we're an incoming migration
> so as not to overwrite shared ram in the ignore-shared migration
> optimisation.
> However, it's got an unexpected side effect that because it skips
> freeing the ROM data, when rom_reset gets called later on, after
> migration (e.g. during a reboot), the ROM does get reset to the original
> file contents.  Because of seabios/x86's weird reboot process
> this confuses a reboot into hanging after a migration.
>
> Fixes: 355477f8c73e9 ("migration: do not rom_reset() during incoming 
> migration")
> https://bugzilla.redhat.com/show_bug.cgi?id=1809380
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hw/core/loader.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)


Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM