[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/16] hw/i386/vmport: Define enum for all commands

From: Liran Alon
Subject: Re: [PATCH v3 08/16] hw/i386/vmport: Define enum for all commands
Date: Sat, 14 Mar 2020 00:40:03 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 13/03/2020 21:59, Philippe Mathieu-Daudé wrote:
On 3/12/20 5:54 PM, Liran Alon wrote:
No functional change.

Defining an enum for all VMPort commands have the following advantages:
* It gets rid of the error-prone requirement to update VMPORT_ENTRIES
when new VMPort commands are added to QEMU.
* It makes it clear to know by looking at one place at the source, what
are all the VMPort commands supported by QEMU.

Reviewed-by: Nikita Leshenko <address@hidden>
Signed-off-by: Liran Alon <address@hidden>
  hw/i386/vmmouse.c        | 18 ++++++------------
  hw/i386/vmport.c         | 11 ++---------
  include/hw/i386/vmport.h | 11 ++++++++++-

Please setup scripts/git.orderfile to ease reviews.

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Oh ok. Will do for next submissions.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]