Re: [PATCH v5 0/4] delay timer_new from init to realize to fix memleaks.

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v5 0/4] delay timer_new from init to realize to fix memleaks.
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
57225b5 hw/misc/mos6522: move timer_new from init() into realize() to avoid 
memleaks
68ae0a2 hw/misc/macio: fix incorrect creation of mos6522's subclasses
5b8325b mac_via: fix incorrect creation of mos6522 device in mac_via
330de48 s390x: fix memleaks in cpu_finalize

=== OUTPUT BEGIN ===
1/4 Checking commit 330de484a515 (s390x: fix memleaks in cpu_finalize)
2/4 Checking commit 5b8325bdb752 (mac_via: fix incorrect creation of mos6522 
device in mac_via)
3/4 Checking commit 68ae0a2ea95b (hw/misc/macio: fix incorrect creation of 
mos6522's subclasses)
ERROR: superfluous trailing semicolon
#62: FILE: hw/misc/macio/pmu.c:745:
+    DeviceState *d = DEVICE(&s->mos6522_pmu);;

total: 1 errors, 0 warnings, 52 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 57225b5cea3b (hw/misc/mos6522: move timer_new from init() 
into realize() to avoid memleaks)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden