[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before '
Re: [PATCH] softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default machine'
Sat, 14 Mar 2020 12:36:53 +0100
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Peter Maydell <address@hidden> writes:
> Currently if you try to ask for the list of CPUs for a target
> architecture which does not specify a default machine type
> you just get an error:
> $ qemu-system-arm -cpu help
> qemu-system-arm: No machine specified, and there is no default
> Use -machine help to list supported machines
> Since the list of CPUs doesn't depend on the machine, this is
> unnecessarily unhelpful. "-device help" has a similar problem.
> Move the checks for "did the user ask for -cpu help or -device help"
> up so they precede the select_machine() call which checks that the
> user specified a valid machine type.
> Signed-off-by: Peter Maydell <address@hidden>
> This has been on-and-off irritating me for years, and it's
> embarrassing how simple the fix turns out to be...
Same here. The patch works as advertized, thus:
Reviewed-by: Markus Armbruster <address@hidden>
Can you offer a completeness argument? We call is_help_option() and
qemu_opt_has_help_opt() from quite a few places.