qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/4] scripts: add a script to generate syscall_nr.h


From: Richard Henderson
Subject: Re: [PATCH v2 1/4] scripts: add a script to generate syscall_nr.h
Date: Sun, 15 Mar 2020 16:13:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 3/14/20 4:39 AM, Laurent Vivier wrote:
> +qemu_arch()
> +{
> +    case "$1" in
> +    arm64)
> +        echo "aarch64"
> +        ;;
> +    *)
> +        upper "$1"
> +        ;;
> +    esac
> +}

I think you can drop the upper here.  That distinction is confusing.  Anyway,
it's only use applies upper again.

With that,
Reviewed-by: Richard Henderson <address@hidden>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]