qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function


From: Gerd Hoffmann
Subject: Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function
Date: Mon, 16 Mar 2020 12:40:07 +0100

  Hi,

> +    if (len > s->recv_used)
> +        len = s->recv_used;

scripts/checkpatch.pl flags a codestyle error here.

> -        if (len > s->recv_used)
> -            len = s->recv_used;

Which is strictly speaking not your fault as you are just moving around
existing code.  It's common practice though that codestyle is fixed up
too when touching code.  Any chance you can make sure the patches pass
checkpatch & resend?

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]