[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function |
Date: |
Mon, 16 Mar 2020 12:40:07 +0100 |
Hi,
> + if (len > s->recv_used)
> + len = s->recv_used;
scripts/checkpatch.pl flags a codestyle error here.
> - if (len > s->recv_used)
> - len = s->recv_used;
Which is strictly speaking not your fault as you are just moving around
existing code. It's common practice though that codestyle is fixed up
too when touching code. Any chance you can make sure the patches pass
checkpatch & resend?
thanks,
Gerd
- [PATCH 0/4] usb-serial: xHCI and timeout fixes, Jason Andryuk, 2020/03/12
- [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function, Jason Andryuk, 2020/03/12
- [PATCH 2/4] usb-serial: chunk data to wMaxPacketSize, Jason Andryuk, 2020/03/12
- [PATCH 3/4] usb-serial: Increase receive buffer to 496, Jason Andryuk, 2020/03/12
- [PATCH 4/4] usb-serial: Fix timeout closing the device, Jason Andryuk, 2020/03/12
- Re: [PATCH 0/4] usb-serial: xHCI and timeout fixes, no-reply, 2020/03/12
- Re: [PATCH 0/4] usb-serial: xHCI and timeout fixes, no-reply, 2020/03/12