Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

[Philippe Mathieu-Daudé]

On 3/16/20 2:49 PM, Peter Maydell wrote:
> On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé <address@hidden> wrote:
> > The semihosting feature is only meaningful when using TCG.
> >
> > So far only the ARM/MIPS/LM32 provide the semihosting feature.
>
> Also m68k, nios2, xtensa. riscv eventually but not yet upstream.
>
> > Do not enable it by default, and let the few targets requiring
> > it to manually select it.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   hw/semihosting/Kconfig | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/semihosting/Kconfig b/hw/semihosting/Kconfig
> > index efe0a30734..06e9262af2 100644
> > --- a/hw/semihosting/Kconfig
> > +++ b/hw/semihosting/Kconfig
> > @@ -1,3 +1,5 @@
> >
> >   config SEMIHOSTING
> > -       bool
> > +    bool
> > +    depends on TCG
> > +    default n
>
> OK, this is the "do not enable by default" -- where is
> the "but do enable by default for the targets that use it"
> part of the config change ?

This is already the default for these targets, see:

commit 16932bb761e52c2ca9397b57af5bdc5bdc5ae6a4
Author: Alex Bennée <address@hidden>
Date:   Mon May 13 15:25:27 2019 +0100

    semihosting: introduce CONFIG_SEMIHOSTING

    There isn't much point building semihosting for platforms that don't
    support it. Introduce a new symbol and enable it only for the
    softmmu targets that need it.

I'll add that information in the description.

> thanks
> -- PMM