[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 11/34] qapi/schema: Clean up around QAPISchemaEntity.conne

From: Eric Blake
Subject: Re: [PATCH v3 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc()
Date: Mon, 16 Mar 2020 12:23:05 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/15/20 9:46 AM, Markus Armbruster wrote:
QAPISchemaEntity calls doc.connect_feature() in .check().  Improper
since commit ee1e6a1f6c8 split .connect_doc() off .check().  Move the
call.  Requires making the children call super().connect_doc() as they

Signed-off-by: Markus Armbruster <address@hidden>
  scripts/qapi/schema.py | 13 +++++++++----
  1 file changed, 9 insertions(+), 4 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]