[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] mmap-alloc: Include osdep.h before checking CONFIG_LI

From: Peter Maydell
Subject: Re: [PATCH v2 2/2] mmap-alloc: Include osdep.h before checking CONFIG_LINUX
Date: Mon, 16 Mar 2020 19:20:02 +0000

On Mon, 16 Mar 2020 at 18:40, Eduardo Habkost <address@hidden> wrote:
> On Mon, Mar 16, 2020 at 06:08:54PM +0000, Peter Maydell wrote:
> > The usual approach is that if you don't have the Linux-specific
> > feature available you quietly fall back to whatever the sensible
> > behaviour is for when the feature isn't present. We definitely
> > don't want to be printing warnings on non-Linux systems that
> > are effectively just saying "you're not running Linux". Same goes
> > for "host happens not to be running a bleeding-edge Linux kernel
> > and this feature isn't available yet".
> I don't think using pmem=on without MAP_SYNC is expected to be a
> supported use case, is it?  If a use case is not supported, the
> sensible behavior is to tell the user it is not supported.

Yeah, that's fair. But the code at the moment does a fallback
to "proceed without SHARED_VALIDATE | SYNC", so I assumed it
was supposed to work.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]