[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/11] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 comm
From: |
Peter Maydell |
Subject: |
[PULL 10/11] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command |
Date: |
Tue, 17 Mar 2020 11:40:38 +0000 |
From: Guenter Roeck <address@hidden>
The Linux kernel recently started using FAST_READ_4 commands.
This results in flash read failures. At the same time, the m25p80
emulation is seen to read 8 more bytes than expected. Adjusting the
expected number of dummy cycles to match FAST_READ fixes the problem.
Fixes: f95c4bffdc4c ("aspeed/smc: snoop SPI transfers to fake dummy cycles")
Reviewed-by: Cédric Le Goater <address@hidden>
Signed-off-by: Guenter Roeck <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
---
hw/ssi/aspeed_smc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 32be2a02b0e..9d5c696d5a1 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -788,11 +788,11 @@ static int aspeed_smc_num_dummies(uint8_t command)
case FAST_READ:
case DOR:
case QOR:
+ case FAST_READ_4:
case DOR_4:
case QOR_4:
return 1;
case DIOR:
- case FAST_READ_4:
case DIOR_4:
return 2;
case QIOR:
--
2.20.1
- [PULL 02/11] hw/arm/fsl-imx6ul: Fix USB interrupt numbers, (continued)
- [PULL 02/11] hw/arm/fsl-imx6ul: Fix USB interrupt numbers, Peter Maydell, 2020/03/17
- [PULL 01/11] hw/usb: Add basic i.MX USB Phy support, Peter Maydell, 2020/03/17
- [PULL 03/11] hw/arm/fsl-imx6ul: Instantiate unimplemented pwm and can devices, Peter Maydell, 2020/03/17
- [PULL 04/11] hw/arm/fsl-imx6ul: Wire up USB controllers, Peter Maydell, 2020/03/17
- [PULL 05/11] hw/arm/fsl-imx6: Wire up USB controllers, Peter Maydell, 2020/03/17
- [PULL 06/11] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write(), Peter Maydell, 2020/03/17
- [PULL 08/11] m25p80: Improve command handling for Jedec commands, Peter Maydell, 2020/03/17
- [PULL 07/11] m25p80: Convert to support tracing, Peter Maydell, 2020/03/17
- [PULL 09/11] m25p80: Improve command handling for unsupported commands, Peter Maydell, 2020/03/17
- [PULL 11/11] hw/arm/pxa2xx: Do not wire up OHCI for PXA255, Peter Maydell, 2020/03/17
- [PULL 10/11] aspeed/smc: Fix number of dummy cycles for FAST_READ_4 command,
Peter Maydell <=
- Re: [PULL 00/11] target-arm queue, Peter Maydell, 2020/03/17