[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an expla
From: |
Markus Armbruster |
Subject: |
[PATCH v4 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation |
Date: |
Tue, 17 Mar 2020 12:54:49 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi/qmp-dispatch.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 91e50fa0dd..44fc368d61 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -162,7 +162,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
g_assert(!ret);
return NULL;
} else if (!ret) {
- /* TODO turn into assertion */
+ /*
+ * When the command's schema has no 'returns', cmd->fn()
+ * leaves @ret null. The QMP spec calls for an empty object
+ * then; supply it.
+ */
ret = QOBJECT(qdict_new());
}
--
2.21.1
- [PATCH v4 08/34] tests/test-qmp-event: Simplify test data setup, (continued)
- [PATCH v4 08/34] tests/test-qmp-event: Simplify test data setup, Markus Armbruster, 2020/03/17
- [PATCH v4 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers, Markus Armbruster, 2020/03/17
- [PATCH v4 02/34] qapi: Belatedly update doc comment for @wait deprecation, Markus Armbruster, 2020/03/17
- [PATCH v4 06/34] tests/test-qmp-cmds: Check responses more thoroughly, Markus Armbruster, 2020/03/17
- [PATCH v4 07/34] tests/test-qmp-cmds: Simplify test data setup, Markus Armbruster, 2020/03/17
- [PATCH v4 16/34] qapi/schema: Change _make_features() to a take feature list, Markus Armbruster, 2020/03/17
- [PATCH v4 23/34] qapi: Simplify how qmp_dispatch() gets the request ID, Markus Armbruster, 2020/03/17
- [PATCH v4 09/34] tests/test-qmp-event: Use qobject_is_equal(), Markus Armbruster, 2020/03/17
- [PATCH v4 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc(), Markus Armbruster, 2020/03/17
- [PATCH v4 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation,
Markus Armbruster <=
- [PATCH v4 30/34] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2020/03/17
- [PATCH v4 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP, Markus Armbruster, 2020/03/17
- [PATCH v4 10/34] tests/test-qmp-event: Check event is actually emitted, Markus Armbruster, 2020/03/17
- [PATCH v4 18/34] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants}, Markus Armbruster, 2020/03/17
- [PATCH v4 27/34] qemu-options: New -compat to set policy for deprecated interfaces, Markus Armbruster, 2020/03/17