Re: [PATCH v4 25/34] qapi: New special feature flag "deprecated"

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 3/17/20 6:54 AM, Markus Armbruster wrote:
>> Unlike regular feature flags, the new special feature flag
>> "deprecated" is recognized by the QAPI generator.  For now, it's only
>> permitted with commands, events, and struct members.  It will be put
>> to use shortly.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>
>> +++ b/docs/devel/qapi-code-gen.txt
>> @@ -683,6 +683,12 @@ Intended use is to have each feature string signal that 
>> this build of
>>   QEMU shows a certain behaviour.
>>     +==== Special features ====
>> +
>> +Feature "deprecated" makes a command, event, or struct member as
>> +deprecated.  It is not supported elsewhere so far.
>
> Reads awkwardly, but I can't tell if it was a typo or an extra
> word. Either "makes a command, event, or struct member deprecated" or
> "marks a command, event, or struct member as deprecated".

I typoed the latter.  Will fix!

> Reviewed-by: Eric Blake <address@hidden>

Thanks!