[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/30] qapi: Replace qmp_dispatch()'s TODO comment by an explanati
From: |
Markus Armbruster |
Subject: |
[PULL 25/30] qapi: Replace qmp_dispatch()'s TODO comment by an explanation |
Date: |
Tue, 17 Mar 2020 22:01:10 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qapi/qmp-dispatch.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 91e50fa0dd..44fc368d61 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -162,7 +162,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
g_assert(!ret);
return NULL;
} else if (!ret) {
- /* TODO turn into assertion */
+ /*
+ * When the command's schema has no 'returns', cmd->fn()
+ * leaves @ret null. The QMP spec calls for an empty object
+ * then; supply it.
+ */
ret = QOBJECT(qdict_new());
}
--
2.21.1
- [PULL 28/30] qmp: constify QmpCommand and list, (continued)
- [PULL 28/30] qmp: constify QmpCommand and list, Markus Armbruster, 2020/03/17
- [PULL 14/30] qapi: Consistently put @features parameter right after @ifcond, Markus Armbruster, 2020/03/17
- [PULL 19/30] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants}, Markus Armbruster, 2020/03/17
- [PULL 26/30] qapi: New special feature flag "deprecated", Markus Armbruster, 2020/03/17
- [PULL 27/30] qapi: Mark deprecated QMP parts with feature 'deprecated', Markus Armbruster, 2020/03/17
- [PULL 17/30] qapi/schema: Change _make_features() to a take feature list, Markus Armbruster, 2020/03/17
- [PULL 22/30] qapi: Inline do_qmp_dispatch() into qmp_dispatch(), Markus Armbruster, 2020/03/17
- [PULL 18/30] qapi/schema: Reorder classes so related ones are together, Markus Armbruster, 2020/03/17
- [PULL 29/30] net: Complete qapi-fication of netdev_add, Markus Armbruster, 2020/03/17
- [PULL 03/30] qapi: Belatedly update doc comment for @wait deprecation, Markus Armbruster, 2020/03/17
- [PULL 25/30] qapi: Replace qmp_dispatch()'s TODO comment by an explanation,
Markus Armbruster <=
- [PULL 13/30] qapi: Add feature flags to remaining definitions, Markus Armbruster, 2020/03/17
- [PULL 16/30] qapi/introspect: Factor out _make_tree(), Markus Armbruster, 2020/03/17
- [PULL 15/30] qapi/introspect: Rename *qlit* to reduce confusion, Markus Armbruster, 2020/03/17
- [PULL 21/30] qapi: Add feature flags to struct members, Markus Armbruster, 2020/03/17
- Re: [PULL 00/30] QAPI patches for 2020-03-17, Peter Maydell, 2020/03/19