qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hmp-cmd: fix a missing_break warning


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hmp-cmd: fix a missing_break warning
Date: Wed, 18 Mar 2020 12:36:03 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/18/20 8:16 AM, Pan Nengyuan wrote:
This fix coverity issues 94417686:
     1260        break;
     CID 94417686: (MISSING_BREAK)
     1261. unterminated_case: The case for value 
"MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD" is not terminated by a 'break' 
statement.
     1261    case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD:
     1262        p->has_throttle_trigger_threshold = true;
     1263        visit_type_int(v, param, &p->throttle_trigger_threshold, &err);
     1264    case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL:

Fixes: dc14a470763c96fd9d360e1028ce38e8c3613a77
Reported-by: Euler Robot <address@hidden>
Signed-off-by: Pan Nengyuan <address@hidden>
---
Cc: address@hidden
---
  monitor/hmp-cmds.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 58724031ea..c882c9f3cc 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -1261,6 +1261,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict 
*qdict)
      case MIGRATION_PARAMETER_THROTTLE_TRIGGER_THRESHOLD:
          p->has_throttle_trigger_threshold = true;
          visit_type_int(v, param, &p->throttle_trigger_threshold, &err);
+        break;
      case MIGRATION_PARAMETER_CPU_THROTTLE_INITIAL:
          p->has_cpu_throttle_initial = true;
          visit_type_int(v, param, &p->cpu_throttle_initial, &err);


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]