[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: Silence clang warning on older glib autoptr usage

From: Eric Blake
Subject: Re: [PATCH] build: Silence clang warning on older glib autoptr usage
Date: Wed, 18 Mar 2020 07:45:51 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/18/20 6:19 AM, Eric Blake wrote:

This wasn't a NetBSD failure. I hit it on my clang-on-x86-64-Ubuntu
setup, and also on FreeBSD. (The latter is just the tests/vm
FreeBSD config, so you can repro that if you need to.)

The ubuntu setup is libglib 2.56.4-0ubuntu0.18.04.4 and
clang 6.0.0-1ubuntu2.

Thanks; I ran:

$ make docker-test-clang@ubuntu1804 DEBUG=1

to confirm that my test snippet does flush out the error in question. However, removing DEBUG=1 takes a long time to run (hmm, maybe I should set TARGET_LIST to speed it up), and did not reproduce the failure for me without the patch (making it hard to tell if the patch made a difference).  I'm still playing with testing, but at least I feel better that this patch is on the right track, now that I have an environment that can reproduce the situation.

Aha - I figured out my problem: I have to apply John's pull request, but not my configure patch, to reproduce the build failure that Peter hit. And with that, I can now state that this patch HAS been fully-tested by me (but giving Tested-by: to my own patch feels weird):

make docker-test-clang@ubuntu1804 TARGETS=x86_64

on the following matrix:

  John's PR =>         excluded included
my patch excluded         pass    fail
my patch included         pass    pass

Looks like the next step is for John to send v2 of the pull request with my configure patch inserted.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]