[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/13] microvm: add acpi support

From: Paolo Bonzini
Subject: Re: [PATCH 00/13] microvm: add acpi support
Date: Thu, 19 Mar 2020 10:59:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 19/03/20 10:33, Gerd Hoffmann wrote:
> On Thu, Mar 19, 2020 at 09:49:55AM +0100, Paolo Bonzini wrote:
>> On 19/03/20 09:01, Gerd Hoffmann wrote:
>>> I know that not supporting ACPI in microvm is intentional.  If you still
>>> don't want ACPI this is perfectly fine, you can use the usual -no-acpi
>>> switch to toggle ACPI support.
>> Could we change -no-acpi into a "-machine acpi=..." property?  Then it
>> can have type OnOffAuto and we can decide whether to enable it by
>> default or not for microvm.
> For all machine types not just microvm I guess?

Yes, please.  Strange that no one has noticed it for all this time!

The main reason for not having ACPI was the time that it took to start;
this is also why I preferred having device tree, but indeed that would
mean no distro kernels (we could probably use U-Boot as the firmware,
but still with a custom kernel).


>> Also, can you confirm that it builds without CONFIG_I440FX and
>> CONFIG_Q35?  You probably need to add "imply ACPI" and possibly some
>> '#include "config-devices.h"' and '#ifdef CONFIG_ACPI' here and there.
> Didn't try that yet, will do.
> cheers,
>   Gerd

reply via email to

[Prev in Thread] Current Thread [Next in Thread]