[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header
From: |
Peter Maydell |
Subject: |
[PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header target_flat.h |
Date: |
Thu, 19 Mar 2020 19:33:21 +0000 |
The target_flat.h file is a QEMU header, so we should include it using
quotes, not angle brackets.
Coverity otherwise is unable to find the header:
"../linux-user/flatload.c", line 40: error #1712: cannot open source file
"target_flat.h"
#include <target_flat.h>
^
because the relevant directory is only on the -iquote path, not the -I path.
Signed-off-by: Peter Maydell <address@hidden>
---
I don't know why Coverity in particular has trouble here but
real compilers don't. Still, the "" is the right thing.
---
linux-user/flatload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 0122ab3afe6..66901f39cc5 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -37,7 +37,7 @@
#include "qemu.h"
#include "flat.h"
-#include <target_flat.h>
+#include "target_flat.h"
//#define DEBUG
--
2.20.1
- [PATCH v2 0/6] Automation of Coverity Scan uploads (via Docker), Peter Maydell, 2020/03/19
- [PATCH v2 1/6] osdep.h: Drop no-longer-needed Coverity workarounds, Peter Maydell, 2020/03/19
- [PATCH v2 2/6] thread.h: Fix Coverity version of qemu_cond_timedwait(), Peter Maydell, 2020/03/19
- [PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header target_flat.h,
Peter Maydell <=
- [PATCH v2 3/6] thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc, Peter Maydell, 2020/03/19
- [PATCH v2 5/6] scripts/run-coverity-scan: Script to run Coverity Scan build, Peter Maydell, 2020/03/19
- [PATCH v2 6/6] scripts/coverity-scan: Add Docker support, Peter Maydell, 2020/03/19