Re: [PULL 0/1] Slirp patches

[Peter Maydell]

On Thu, 19 Mar 2020 at 11:33, Marc-André Lureau
<address@hidden> wrote:
>
> The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' 
> into staging (2020-03-19 10:18:07 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/elmarco/qemu.git tags/slirp-pull-request
>
> for you to fetch changes up to 9f6b9fcc153f6d4f2e10193014d2eaf7329fa181:
>
>   slirp: update submodule to v4.2.0 + mingw-fix (2020-03-19 12:17:43 +0100)
>
> ----------------------------------------------------------------

Hi; this fails to build on NetBSD:

In file included from /usr/pkg/lib/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/pkg/include/glib-2.0/glib/gtypes.h:32,
                 from /usr/pkg/include/glib-2.0/glib/galloca.h:32,
                 from /usr/pkg/include/glib-2.0/glib.h:30,
                 from /home/qemu/qemu-test.1QzWG1/src/slirp/src/util.h:27,
                 from /home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.h:47,
                 from /home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:25:
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c: In function 'slirp_new':
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:277:29: error:
'SlirpConfig {aka const struct SlirpConfig}' has no member named
'if_data'
     g_return_val_if_fail(cfg->if_mtu >= IF_MTU_MIN || cfg->if_mtu == 0, NULL);
                             ^
/usr/pkg/include/glib-2.0/glib/gmacros.h:928:8: note: in definition of
macro '_G_BOOLEAN_EXPR'
    if (expr)                                    \
        ^
/usr/pkg/include/glib-2.0/glib/gmessages.h:599:9: note: in expansion
of macro 'G_LIKELY'
     if (G_LIKELY (expr)) \
         ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:277:5: note: in
expansion of macro 'g_return_val_if_fail'
     g_return_val_if_fail(cfg->if_mtu >= IF_MTU_MIN || cfg->if_mtu == 0, NULL);
     ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:277:58: error:
'SlirpConfig {aka const struct SlirpConfig}' has no member named
'if_data'
     g_return_val_if_fail(cfg->if_mtu >= IF_MTU_MIN || cfg->if_mtu == 0, NULL);
fcntl(): Invalid argument
                                                          ^
/usr/pkg/include/glib-2.0/glib/gmacros.h:928:8: note: in definition of
macro '_G_BOOLEAN_EXPR'
    if (expr)                                    \
        ^
/usr/pkg/include/glib-2.0/glib/gmessages.h:599:9: note: in expansion
of macro 'G_LIKELY'
     if (G_LIKELY (expr)) \
         ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:277:5: note: in
expansion of macro 'g_return_val_if_fail'
     g_return_val_if_fail(cfg->if_mtu >= IF_MTU_MIN || cfg->if_mtu == 0, NULL);
     ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:278:29: error:
'SlirpConfig {aka const struct SlirpConfig}' has no member named
'if_data'
     g_return_val_if_fail(cfg->if_mtu <= IF_MTU_MAX, NULL);
                             ^
/usr/pkg/include/glib-2.0/glib/gmacros.h:928:8: note: in definition of
macro '_G_BOOLEAN_EXPR'
    if (expr)                                    \
        ^
/usr/pkg/include/glib-2.0/glib/gmessages.h:599:9: note: in expansion
of macro 'G_LIKELY'
     if (G_LIKELY (expr)) \
         ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:278:5: note: in
expansion of macro 'g_return_val_if_fail'
     g_return_val_if_fail(cfg->if_mtu <= IF_MTU_MAX, NULL);
     ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:324:10: error:
'Slirp {aka struct Slirp}' has no member named 'if_data'
     slirp->if_mtu = cfg->if_mtu == 0 ? IF_MTU_DEFAULT : cfg->if_mtu;
          ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:324:24: error:
'SlirpConfig {aka const struct SlirpConfig}' has no member named
'if_data'
     slirp->if_mtu = cfg->if_mtu == 0 ? IF_MTU_DEFAULT : cfg->if_mtu;
                        ^
/home/qemu/qemu-test.1QzWG1/src/slirp/src/slirp.c:324:60: error:
'SlirpConfig {aka const struct SlirpConfig}' has no member named
'if_data'
     slirp->if_mtu = cfg->if_mtu == 0 ? IF_MTU_DEFAULT : cfg->if_mtu;
                                                            ^


thanks
-- PMM