[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] iotests: Increase pause_wait() timeout

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/3] iotests: Increase pause_wait() timeout
Date: Fri, 20 Mar 2020 11:21:21 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/13/20 9:36 AM, Kevin Wolf wrote:
Waiting for only 1 second proved to be too short on a loaded system,
resulting in false positives when testing pull requests. Increase the
timeout a bit to make this less likely.

Signed-off-by: Kevin Wolf <address@hidden>
  tests/qemu-iotests/iotests.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index b859c303a2..7bc4934cd2 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -925,7 +925,7 @@ class QMPTestCase(unittest.TestCase):
          self.assert_qmp(event, 'data/type', 'mirror')
def pause_wait(self, job_id='job0'):
-        with Timeout(1, "Timeout waiting for job to pause"):
+        with Timeout(3, "Timeout waiting for job to pause"):
              while True:
                  result = self.vm.qmp('query-block-jobs')
                  found = False

I wonder if this might be more accurate:

  load_timeout = math.ceil(os.getloadavg()[0])
  with Timeout(1 + load_timeout, "Timeout waiting for job to pause"):

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]