[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/27] ppc405_boards: Don't size flash memory to
Re: [Qemu-devel] [PULL 08/27] ppc405_boards: Don't size flash memory to match backing image
Fri, 20 Mar 2020 17:10:43 +0100
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Peter Maydell <address@hidden> writes:
> On Mon, 11 Mar 2019 at 22:10, Markus Armbruster <address@hidden> wrote:
>> Machine "ref405ep" maps its flash memory at address 2^32 - image size.
>> Image size is rounded up to the next multiple of 64KiB. Useless,
>> because pflash_cfi02_realize() fails with "failed to read the initial
>> flash content" unless the rounding is a no-op.
>> If the image size exceeds 0x80000 Bytes, we overlap first SRAM, then
>> other stuff. No idea how that would play out, but useful outcomes
>> seem unlikely.
>> Map the flash memory at fixed address 0xFFF80000 with size 512KiB,
>> regardless of image size, to match the physical hardware.
>> Machine "taihu" maps its boot flash memory similarly. The code even
>> has a comment /* XXX: should check that size is 2MB */, followed by
>> disabled code to adjust the size to 2MiB regardless of image size.
>> Its code to map its application flash memory looks the same, except
>> there the XXX comment asks for 32MiB, and the code to adjust the size
>> isn't disabled. Note that pflash_cfi02_realize() fails with "failed
>> to read the initial flash content" for images smaller than 32MiB.
>> Map the boot flash memory at fixed address 0xFFE00000 with size 2MiB,
>> to match the physical hardware. Delete dead code from application
>> flash mapping, and simplify some.
>> Cc: David Gibson <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Acked-by: David Gibson <address@hidden>
>> Reviewed-by: Alex Bennée <address@hidden>
>> Message-Id: <address@hidden>
>> hw/ppc/ppc405_boards.c | 36 ++++++++++++------------------------
>> 1 file changed, 12 insertions(+), 24 deletions(-)
> Hi; Coverity has just noticed a minor bug in this patch
> (CID 1421917):
> Anybody feel like sending a patch?
> -- PMM
Philippe just posted the obvious fix.