[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0 04/11] hw/input/adb-kbd: Remove dead assignment

From: BALATON Zoltan
Subject: Re: [PATCH-for-5.0 04/11] hw/input/adb-kbd: Remove dead assignment
Date: Sat, 21 Mar 2020 13:58:33 +0100 (CET)
User-agent: Alpine 2.22 (BSF 395 2020-01-19)

On Sat, 21 Mar 2020, Philippe Mathieu-Daudé wrote:
Fix warning reported by Clang static code analyzer:

   CC      hw/input/adb-kbd.o
 hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read
     olen = 0;
     ^      ~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
hw/input/adb-kbd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/hw/input/adb-kbd.c b/hw/input/adb-kbd.c
index 0ba8207589..b0565be21b 100644
--- a/hw/input/adb-kbd.c
+++ b/hw/input/adb-kbd.c
@@ -197,7 +197,6 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf)
    int keycode;
    int olen;

-    olen = 0;
    if (s->count == 0) {
        return 0;

Is this variable still needed at all? Looks like it's a remnant after a1f4971863 that can now only return 0 or 2 so you could just remove this variable and return 2 where now it's assigned as 2 or change return olen at the end to return 2 or maybe keep olen and change the return 0 above to return olen to silence warning but I think this could be cleaned up.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]