Re: [PULL v2 0/1] Slirp patches

[Peter Maydell]

On Fri, 20 Mar 2020 at 15:51, Marc-André Lureau
<address@hidden> wrote:
>
> The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' 
> into staging (2020-03-19 10:18:07 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/elmarco/qemu.git tags/slirp-pull-request
>
> for you to fetch changes up to aa63573a84c92b14c23f557fcc93a12b1a93c187:
>
>   slirp: update submodule to v4.2.0+ (2020-03-20 16:50:12 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Marc-André Lureau (1):
>   slirp: update submodule to v4.2.0+
>
>  slirp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi; this fails to build on most platforms (though it works on
the BSDs, oddly):

/home/ubuntu/qemu/slirp/src/version.c: In function ‘slirp_version_string’:
/home/ubuntu/qemu/slirp/src/version.c:7:12: error:
‘SLIRP_VERSION_STRING’ undeclared (first use in this function); did
you mean ‘LIBSLIRP_VERSION_H_’?
     return SLIRP_VERSION_STRING;
            ^~~~~~~~~~~~~~~~~~~~
            LIBSLIRP_VERSION_H_
/home/ubuntu/qemu/slirp/src/version.c:7:12: note: each undeclared
identifier is reported only once for each function it appears in
/home/ubuntu/qemu/slirp/src/version.c:8:1: error: control reaches end
of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors
Makefile:45: recipe for target
'/home/ubuntu/qemu/build/all/slirp/src/version.o' failed


thanks
-- PMM