qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ppc/ppc405_boards: Remove unnecessary NULL check


From: David Gibson
Subject: Re: [PATCH] ppc/ppc405_boards: Remove unnecessary NULL check
Date: Mon, 23 Mar 2020 13:34:24 +1100

On Sun, Mar 22, 2020 at 10:06:13AM +0000, Peter Maydell wrote:
> On Sun, 22 Mar 2020 at 08:50, David Gibson <address@hidden> wrote:
> >
> > On Fri, Mar 20, 2020 at 04:57:40PM +0100, Philippe Mathieu-Daudé wrote:
> > > This code is inside the "if (dinfo)" condition, so testing
> > > again here whether it is NULL is unnecessary.
> > >
> > > Fixes: dd59bcae7 (Don't size flash memory to match backing image)
> > > Reported-by: Coverity (CID 1421917)
> > > Suggested-by: Peter Maydell <address@hidden>
> > > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> >
> > Applied to ppc-for-5.1.
> 
> This would be OK for 5.0 too at this stage.

Understood, I've moved this into the ppc-for-5.0 tree.

> 
> thanks
> -- PMM
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]