[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user, configure: improve syscall_nr.h dependencies che

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] linux-user, configure: improve syscall_nr.h dependencies checking
Date: Mon, 23 Mar 2020 12:45:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/23/20 12:41 PM, Laurent Vivier wrote:
This is mostly a fix for in-tree build.

It removes errors on .d directories:

   grep: ./.gitlab-ci.d: Is a directory
   grep: ./scripts/qemu-guest-agent/fsfreeze-hook.d: Is a directory

and improves performance by only checking <ARCH>-linux-user directories.

Reported-by: BALATON Zoltan <address@hidden>
Tested-by: BALATON Zoltan <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
  configure | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index 4f12cd01777e..da09c3589572 100755
--- a/configure
+++ b/configure
@@ -1910,9 +1910,9 @@ for arch in alpha hppa m68k xtensa sh4 microblaze arm ppc 
s390x sparc sparc64 \
      # remove the file if it has been generated in the source directory
      rm -f "${source_path}/linux-user/${arch}/syscall_nr.h"
      # remove the dependency files
-    find . -name "*.d" \
-           -exec grep -q "${source_path}/linux-user/${arch}/syscall_nr.h" {} 
\; \
-           -exec rm {} \;
+    test -d ${arch}-linux-user && find ${arch}-linux-user -type f -name "*.d" \
+         -exec grep -q "${source_path}/linux-user/${arch}/syscall_nr.h" {} \; \
+         -exec rm {} \;
if test -z "$python"

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]