[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/5] allow vu_message_read to be replaced
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v5 1/5] allow vu_message_read to be replaced |
Date: |
Mon, 23 Mar 2020 14:50:05 +0000 |
On Mon, Mar 09, 2020 at 06:03:38PM +0800, Coiby Xu wrote:
> diff --git a/contrib/libvhost-user/libvhost-user.h
> b/contrib/libvhost-user/libvhost-user.h
> index 6fc8000e99..7e3f0c8598 100644
> --- a/contrib/libvhost-user/libvhost-user.h
> +++ b/contrib/libvhost-user/libvhost-user.h
> @@ -30,6 +30,8 @@
>
> #define VHOST_MEMORY_MAX_NREGIONS 8
>
> +#define VHOST_USER_HDR_SIZE offsetof(VhostUserMsg, payload.u64)
> +
> typedef enum VhostSetConfigType {
> VHOST_SET_CONFIG_TYPE_MASTER = 0,
> VHOST_SET_CONFIG_TYPE_MIGRATION = 1,
> @@ -205,6 +207,7 @@ typedef uint64_t (*vu_get_features_cb) (VuDev *dev);
> typedef void (*vu_set_features_cb) (VuDev *dev, uint64_t features);
> typedef int (*vu_process_msg_cb) (VuDev *dev, VhostUserMsg *vmsg,
> int *do_reply);
> +typedef bool (*vu_read_msg_cb) (VuDev *dev, int sock, VhostUserMsg *vmsg);
> typedef void (*vu_queue_set_started_cb) (VuDev *dev, int qidx, bool started);
> typedef bool (*vu_queue_is_processed_in_order_cb) (VuDev *dev, int qidx);
> typedef int (*vu_get_config_cb) (VuDev *dev, uint8_t *config, uint32_t len);
> @@ -373,6 +376,8 @@ struct VuDev {
> bool broken;
> uint16_t max_queues;
>
> + /* allowing vu_read_msg_cb to be replaced */
> + vu_read_msg_cb read_msg;
Please document this function pointer fully so it's clear how custom
implementations of this function should behave. The return value should
be explained.
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [PATCH v5 0/5] vhost-user block device backend implementation, Coiby Xu, 2020/03/09
- [PATCH v5 1/5] allow vu_message_read to be replaced, Coiby Xu, 2020/03/09
- Re: [PATCH v5 1/5] allow vu_message_read to be replaced,
Stefan Hajnoczi <=
- [PATCH v5 2/5] generic vhost user server, Coiby Xu, 2020/03/09
- [PATCH v5 4/5] a standone-alone tool to directly share disk image file via vhost-user protocol, Coiby Xu, 2020/03/09
- [PATCH v5 3/5] vhost-user block device backend server, Coiby Xu, 2020/03/09
- [PATCH v5 5/5] new qTest case to test the vhost-user-blk-server, Coiby Xu, 2020/03/09
- Re: [PATCH v5 0/5] vhost-user block device backend implementation, no-reply, 2020/03/09