[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-5.0 v2 00/11] misc: Trivial static code analyzer fixes
Date: Mon, 23 Mar 2020 16:01:04 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/23/20 3:55 PM, Laurent Vivier wrote:
Le 23/03/2020 à 15:45, Philippe Mathieu-Daudé a écrit :
On 3/23/20 3:32 PM, Laurent Vivier wrote:
Le 21/03/2020 à 15:40, Philippe Mathieu-Daudé a écrit :
Fix trivial warnings reported by the Clang static code analyzer.

Since v1:
- Addressed Markus/Zoltan/Aleksandar review comments

Philippe Mathieu-Daudé (11):
    block: Avoid dead assignment
    blockdev: Remove dead assignment
    hw/i2c/pm_smbus: Remove dead assignment
    hw/input/adb-kbd: Remove dead assignment
    hw/ide/sii3112: Remove dead assignment
    hw/isa/i82378: Remove dead assignment
    hw/gpio/aspeed_gpio: Remove dead assignment
    hw/timer/exynos4210_mct: Remove dead assignments
    hw/timer/stm32f2xx_timer: Remove dead assignment
    hw/timer/pxa2xx_timer: Add assertion to silent static analyzer
    hw/scsi/esp-pci: Remove dead assignment

   block.c                    | 2 +-
   blockdev.c                 | 2 +-
   hw/gpio/aspeed_gpio.c      | 2 +-
   hw/i2c/pm_smbus.c          | 1 -
   hw/ide/sii3112.c           | 5 +++--
   hw/input/adb-kbd.c         | 6 +-----
   hw/isa/i82378.c            | 8 ++++----
   hw/scsi/esp-pci.c          | 1 -
   hw/timer/exynos4210_mct.c  | 3 ---
   hw/timer/pxa2xx_timer.c    | 1 +
   hw/timer/stm32f2xx_timer.c | 1 -
   11 files changed, 12 insertions(+), 20 deletions(-)

I think your series covers cases already covered by:

[PATCH v3 00/12] redundant code: Fix warnings reported by Clang static
code analyzer

Unfortunately [for me...] I don't have v3 in my INBOX... *sigh*
This was 3 weeks ago. *sigh*.

I can see the series in the archives:
But I can't find the outcome, was it queued in the trivial tree?
Any idea when this will be merged in the master tree?

Some patches are already merged via trivial (1, 2 (should go by SCSI
queue) 3, 5, 6, 7, 9, 11 (by USB queue), 12).

But others needed R-b tags or new version. I didn't check which of your
patches are already covered by this series.

I'm sorry to not have checked your series earlier...

Don't be sorry, the problem is my INBOX that is unreliable.

I was using NNTP last month until I heard it was working properly again, which is not the case apparently. I'll try to find them on NNTP and review them.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]