[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 06/11] configure: disable MTTCG for MIPS guests
From: |
Alex Bennée |
Subject: |
[PATCH v1 06/11] configure: disable MTTCG for MIPS guests |
Date: |
Mon, 23 Mar 2020 16:15:09 +0000 |
While debugging check-acceptance failures I found an instability in
the mips64el test case. Briefly the test case:
retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \
-display none -vga none -serial mon:stdio \
-machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \
-cpu I6400 -smp 8 -vga std \
-append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1"
\
--no-reboot
Reports about a 9% failure rate:
Results summary:
0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation)
-6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation)
Ran command 100 times, 91 passes
When re-run with "--accel tcg,thread=single" the instability goes
away.
Results summary:
0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation)
Ran command 100 times, 100 passes
Which seems to indicate there is some aspect of the MIPS MTTCG fixes
that has been missed. Ideally we would fix that but I'm afraid I don't
have time to investigate and am not super familiar with the
architecture anyway. In lieu of someone tracking down the failure lets
disable it for now.
Signed-off-by: Alex Bennée <address@hidden>
Acked-by: Philippe Mathieu-Daudé <address@hidden>
Cc: Aleksandar Markovic <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Aleksandar Rikalo <address@hidden>
---
v2
- only drop mip64le
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 4f12cd01777..a83c6450840 100755
--- a/configure
+++ b/configure
@@ -7885,7 +7885,7 @@ case "$target_name" in
TARGET_SYSTBL_ABI=n32
;;
mips64|mips64el)
- mttcg="yes"
+ mttcg="no"
TARGET_ARCH=mips64
TARGET_BASE_ARCH=mips
echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak
--
2.20.1
- [PATCH v1 for 5.0 00/11] testing/next, Alex Bennée, 2020/03/23
- [PATCH v1 08/11] tests/docker: Install gcrypt devel package in Debian image, Alex Bennée, 2020/03/23
- [PATCH v1 04/11] tests/vm: update NetBSD to 9.0, Alex Bennée, 2020/03/23
- [PATCH v1 03/11] tests/vm: update FreeBSD to 12.1, Alex Bennée, 2020/03/23
- [PATCH v1 09/11] tests/docker: Use Python3 PyYAML in the Fedora image, Alex Bennée, 2020/03/23