qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v41 01/21] target/avr: Add outward facing interfaces and core


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v41 01/21] target/avr: Add outward facing interfaces and core CPU logic
Date: Mon, 23 Mar 2020 20:19:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/23/20 7:03 PM, Richard Henderson wrote:
On 3/23/20 10:03 AM, Michael Rolnik wrote:
Hi Philippe.

It's been a while. let me think about it and get back to you. what is your
concern ?

We are using this series with Joaquin for a Google Summit of Code project, so we are noticing some bugs and fixing them.
As it has not been merged, we work in a fork.
Since it was posted on the list, I prefer to ask on the list than directly to you.


It shouldn't be there.  See commit 1f5c00cfdb81.

Ah it has been moved to cpu_common_reset, thanks :)
I suppose it is because this port is based on some quite old work.


     > +    memset(env->r, 0, sizeof(env->r));
     > +
     > +    tlb_flush(cs);

     Why are you calling tlb_flush() here?


r~





reply via email to

[Prev in Thread] Current Thread [Next in Thread]