Re: [PATCH v41 01/21] target/avr: Add outward facing interfaces and core CPU logic

[Michael Rolnik]

thanks Philippe.

On Mon, Mar 23, 2020 at 9:20 PM Philippe Mathieu-Daudé <address@hidden> wrote:

On 3/23/20 7:03 PM, Richard Henderson wrote:
> On 3/23/20 10:03 AM, Michael Rolnik wrote:
>> Hi Philippe.
>>
>> It's been a while. let me think about it and get back to you. what is your
>> concern ?

We are using this series with Joaquin for a Google Summit of Code
project, so we are noticing some bugs and fixing them.
As it has not been merged, we work in a fork.
Since it was posted on the list, I prefer to ask on the list than
directly to you.

>
> It shouldn't be there.  See commit 1f5c00cfdb81.

Ah it has been moved to cpu_common_reset, thanks :)
I suppose it is because this port is based on some quite old work.

>
>>      > +    memset(env->r, 0, sizeof(env->r));
>>      > +
>>      > +    tlb_flush(cs);
>>
>>      Why are you calling tlb_flush() here?
>
>
> r~
>

--

Best Regards,
Michael Rolnik