[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icel

From: Tao Xu
Subject: Re: [PATCH v2] target/i386: Add ARCH_CAPABILITIES related bits into Icelake-Server CPU model
Date: Tue, 24 Mar 2020 08:23:41 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 3/24/2020 2:39 AM, Eduardo Habkost wrote:
On Mon, Mar 23, 2020 at 10:58:16AM +0800, Xiaoyao Li wrote:
On 3/23/2020 10:32 AM, Tao Xu wrote:
Hi Xiaoyao,

May be you can add .note for this new version.

for example:

+                .version = 3,
+                .note = "ARCH_CAPABILITIES",
+                .props = (PropValue[]) {

Hi Paolo and Eduardo,

Need I spin a new version to add the .note ?
Maybe you can add it when queue?

Please send a follow up patch so we don't hold a bug fix because
of something that's just cosmetic.  I will queue this patch.  We
still need a new version of "target/i386: Add notes for versioned
CPU models"[1], don't we?

[1] https://lore.kernel.org/qemu-devel/address@hidden/

I am sorry for misunderstanding your comments in that patch[1]. I will submit a new version of this patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]