[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/12] tests/acceptance: Remove shebang header
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 07/12] tests/acceptance: Remove shebang header |
Date: |
Tue, 24 Mar 2020 10:19:10 +0000 |
User-agent: |
mu4e 1.3.10; emacs 28.0.50 |
Philippe Mathieu-Daudé <address@hidden> writes:
> Patch created mechanically by running:
>
> $ chmod 644 $(git grep -lF '#!/usr/bin/env python' \
> | xargs grep -L 'if __name__.*__main__')
> $ sed -i "/^#\!\/usr\/bin\/\(env\ \)\?python.\?$/d" \
> $(git grep -lF '#!/usr/bin/env python' \
> | xargs grep -L 'if __name__.*__main__')
OK, but my question is why? Aren't shebangs considered good practice for
finding the executable for a script?
If the acceptance scripts are special in this regard we should say why
in the commit message.
>
> Reported-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Suggested-by: Stefan Hajnoczi <address@hidden>
> Reviewed-by: Wainer dos Santos Moschetta <address@hidden>
> Acked-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/acceptance/virtio_seg_max_adjust.py | 1 -
> tests/acceptance/x86_cpu_model_versions.py | 1 -
> 2 files changed, 2 deletions(-)
> mode change 100755 => 100644 tests/acceptance/virtio_seg_max_adjust.py
>
> diff --git a/tests/acceptance/virtio_seg_max_adjust.py
> b/tests/acceptance/virtio_seg_max_adjust.py
> old mode 100755
> new mode 100644
> index 5458573138..8d4f24da49
> --- a/tests/acceptance/virtio_seg_max_adjust.py
> +++ b/tests/acceptance/virtio_seg_max_adjust.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
> #
> # Test virtio-scsi and virtio-blk queue settings for all machine types
> #
> diff --git a/tests/acceptance/x86_cpu_model_versions.py
> b/tests/acceptance/x86_cpu_model_versions.py
> index 90558d9a71..01ff614ec2 100644
> --- a/tests/acceptance/x86_cpu_model_versions.py
> +++ b/tests/acceptance/x86_cpu_model_versions.py
> @@ -1,4 +1,3 @@
> -#!/usr/bin/env python
> #
> # Basic validation of x86 versioned CPU models and CPU model aliases
> #
--
Alex Bennée
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 07/12] tests/acceptance: Remove shebang header,
Alex Bennée <=