[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hm
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] monitor/hmp-cmds: remove redundant check for tls_authz in hmp_info_migrate_parameters |
Date: |
Tue, 24 Mar 2020 10:27:29 +0000 |
User-agent: |
Mutt/1.13.3 (2020-01-12) |
* Mao Zhongyi (address@hidden) wrote:
> 'params->has_tls_authz = true' has been hardcoded as true in
> qmp_query_migrate_parameters, so remove the redundant check.
>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
> monitor/hmp-cmds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index f8be6bbb16..d18826309b 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -461,7 +461,7 @@ void hmp_info_migrate_parameters(Monitor *mon, const
> QDict *qdict)
> params->max_postcopy_bandwidth);
> monitor_printf(mon, "%s: '%s'\n",
> MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ),
> - params->has_tls_authz ? params->tls_authz : "");
> + params->tls_authz);
> }
>
> qapi_free_MigrationParameters(params);
That's OK, but we may as well combine it with the previous one.
Dave
> --
> 2.17.1
>
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK