Re: [PULL 0/5] Linux user for 5.0 patches

[Laurent Vivier]

Le 24/03/2020 à 12:00, address@hidden a écrit :
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PULL 0/5] Linux user for 5.0 patches
> Message-id: address@hidden
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Switched to a new branch 'test'
> 58fa059 linux-user: Flush out implementation of gettimeofday
> f253e7a linux-user: Add x86_64 vsyscall page to /proc/self/maps
> ad06327 linux-user/i386: Emulate x86_64 vsyscalls
> 2dccb44 linux-user/i386: Split out gen_signal
> 1ab05c1 target/i386: Renumber EXCP_SYSCALL
> 
> === OUTPUT BEGIN ===
> 1/5 Checking commit 1ab05c10ed02 (target/i386: Renumber EXCP_SYSCALL)
> 2/5 Checking commit 2dccb4427740 (linux-user/i386: Split out gen_signal)
> 3/5 Checking commit ad0632716d07 (linux-user/i386: Emulate x86_64 vsyscalls)
> 4/5 Checking commit f253e7a47cf4 (linux-user: Add x86_64 vsyscall page to 
> /proc/self/maps)
> ERROR: trailing whitespace
> #32: FILE: linux-user/syscall.c:7152:
> +    dprintf(fd, TARGET_FMT_lx "-" TARGET_FMT_lx $
> 
> total: 1 errors, 0 warnings, 16 lines checked
> 
> Patch 4/5 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 5/5 Checking commit 58fa0592ae77 (linux-user: Flush out implementation of 
> gettimeofday)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden
> 

Sorry, fixed that on previous PR, not in this new one.

I'm going to send a v2 shortly.

Thanks,
Laurent