Re: [PATCH v6 2/8] i2c: i801: Use GPIO_LOOKUP() helper macro

[Jean Delvare]

On Tue, 24 Mar 2020 14:56:47 +0100, Geert Uytterhoeven wrote:
> i801_add_mux() fills in the GPIO lookup table by manually populating an
> array of gpiod_lookup structures.  Use the existing GPIO_LOOKUP() helper
> macro instead, to relax a dependency on the gpiod_lookup structure's
> member names.
> 
> Signed-off-by: Geert Uytterhoeven <address@hidden>
> Cc: Jean Delvare <address@hidden>
> Cc: address@hidden
> ---
> While this patch is a dependency for "[PATCH v6 4/8] gpiolib: Add
> support for GPIO lookup by line name", it can be applied independently.
> But an Acked-by would be nice, too.
> 
> Cover letter and full series at
> https://lore.kernel.org/r/address@hidden/
> 
> v6:
>   - New.
> ---
>  drivers/i2c/busses/i2c-i801.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index ca4f096fef749302..8e64a71bea684cc7 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1444,9 +1444,9 @@ static int i801_add_mux(struct i801_priv *priv)
>               return -ENOMEM;
>       lookup->dev_id = "i2c-mux-gpio";
>       for (i = 0; i < mux_config->n_gpios; i++) {
> -             lookup->table[i].chip_label = mux_config->gpio_chip;
> -             lookup->table[i].chip_hwnum = mux_config->gpios[i];
> -             lookup->table[i].con_id = "mux";
> +             lookup->table[i] = (struct gpiod_lookup)
> +                     GPIO_LOOKUP(mux_config->gpio_chip,
> +                                 mux_config->gpios[i], "mux", 0);
>       }
>       gpiod_add_lookup_table(lookup);
>       priv->lookup = lookup;

Reviewed-by: Jean Delvare <address@hidden>

-- 
Jean Delvare
SUSE L3 Support