Re: [PATCH v5 3/3] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write()

[Philippe Mathieu-Daudé]

On 3/25/20 1:16 PM, Philippe Mathieu-Daudé wrote:
> On 3/25/20 3:59 AM, Chen Qun wrote:
> > Clang static code analyzer show warning:
> > hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is 
> > never read
> >          index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> >          ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is 
> > never read
> >          index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> >          ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is 
> > never read
> >          index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> >          ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Reported-by: Euler Robot <address@hidden>
> > Signed-off-by: Chen Qun <address@hidden>
> > Reviewed-by: Laurent Vivier <address@hidden>
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Oh and per 
https://www.mail-archive.com/address@hidden/msg691384.html:

Reviewed-by: Alistair Francis <address@hidden>

> > ---
> > Cc: Igor Mitsyanko <address@hidden>
> > Cc: Peter Maydell <address@hidden>
> > ---
> >   hw/timer/exynos4210_mct.c | 4 ----
> >   1 file changed, 4 deletions(-)
> >
> > diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c
> > index 944120aea5..570cf7075b 100644
> > --- a/hw/timer/exynos4210_mct.c
> > +++ b/hw/timer/exynos4210_mct.c
> > @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, 
> > hwaddr offset,
> >       case L0_TCNTB: case L1_TCNTB:
> >           lt_i = GET_L_TIMER_IDX(offset);
> > -        index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> >           /*
> >            * TCNTB is updated to internal register only after CNT 
> > expired.
> > @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, 
> > hwaddr offset,
> >       case L0_ICNTB: case L1_ICNTB:
> >           lt_i = GET_L_TIMER_IDX(offset);
> > -        index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> >           s->l_timer[lt_i].reg.wstat |= L_WSTAT_ICNTB_WRITE;
> >           s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] = value &
> > @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, 
> > hwaddr offset,
> >       case L0_FRCNTB: case L1_FRCNTB:
> >           lt_i = GET_L_TIMER_IDX(offset);
> > -        index = GET_L_TIMER_CNT_REG_IDX(offset, lt_i);
> > -
> >           DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value);
> >           s->l_timer[lt_i].reg.wstat |= L_WSTAT_FRCCNTB_WRITE;