[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration

From: Oksana Voshchana
Subject: Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration
Date: Wed, 25 Mar 2020 16:10:10 +0200

Hi Philippe
Thanks for the review
I have some comments

On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé <address@hidden> wrote:
Hi Oksana,

v2 was
https://www.mail-archive.com/address@hidden/msg682899.html, so
this is v3. Please increment the version in the patch subject.

You could also send a simple "ping" to the specific patch, instead of
resending it.

On 3/25/20 12:31 PM, Oksana Vohchana wrote:
> The exec migration test isn't run a whole test scenario.
> This patch fixes it
> Signed-off-by: Oksana Vohchana <address@hidden>

v1 of this patch has already received reviewers tags
please collect them and keep them when you resend the same patch:
I have reposted patch without this fix because this change isn't related to the series:
Is it make sense to keep this fix as a separate patch?
Fixes: 2e768cb682bf
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Wainer dos Santos Moschetta <address@hidden>

> ---
>   tests/acceptance/migration.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
> index a8367ca023..0365289cda 100644
> --- a/tests/acceptance/migration.py
> +++ b/tests/acceptance/migration.py
> @@ -70,8 +70,8 @@ class Migration(Test):
>       @skipUnless(find_command('nc', default=False), "'nc' command not found")
>       def test_migration_with_exec(self):
> -        """
> -        The test works for both netcat-traditional and netcat-openbsd packages
> -        """
> +        """The test works for both netcat-traditional and netcat-openbsd packages."""

Btw why are you changing the comment style?
I got failure in PEP257

>           free_port = self._get_free_port()
>           dest_uri = 'exec:nc -l localhost %u' % free_port
> +        src_uri = 'exec:nc localhost %u' % free_port
> +        self.do_migrate(dest_uri, src_uri)

Alex, if there is no Python testing pullreq, can you take this patch via
your testing tree?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]