[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] s390x: protvirt: Fix stray error_report_err in s390_machine_prot

From: Janosch Frank
Subject: [PATCH] s390x: protvirt: Fix stray error_report_err in s390_machine_protect
Date: Thu, 26 Mar 2020 10:05:05 -0400

In case the protection of the machine fails at s390_pv_vm_enable(),
we'll currently report the local_error variable. Problem is that
there's no migration blocker error that we can report at this point so
the pointer is always NULL which leads to a SEGFAULT.

Let's remove the error report.

Signed-off-by: Janosch Frank <address@hidden>
Reported-by: Marc Hartmayer <address@hidden>
Fixes: 520935eedf941da3 ("s390x: protvirt: Add migration blocker")
 hw/s390x/s390-virtio-ccw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 3cf19c99f3468b7d..855ecf370d6e82fa 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -358,7 +358,6 @@ static int s390_machine_protect(S390CcwMachineState *ms)
     rc = s390_pv_vm_enable();
     if (rc) {
-        error_report_err(local_err);
         return rc;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]